andygrove opened a new pull request, #3054:
URL: https://github.com/apache/datafusion-comet/pull/3054
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Refactored `sum_int.rs` from a single accumulator with eval mode branches
inside loops into 6 separate accumulator implementations:
Single-row accumulators:
- SumIntegerAccumulatorLegacy - uses wrapping arithmetic (no overflow
checking)
- SumIntegerAccumulatorAnsi - uses checked arithmetic, returns error on
overflow
- SumIntegerAccumulatorTry - uses checked arithmetic, returns None on
overflow, tracks has_all_nulls
Groups accumulators:
- SumIntGroupsAccumulatorLegacy
- SumIntGroupsAccumulatorAnsi
- SumIntGroupsAccumulatorTry
Key changes:
- SumInteger::accumulator() and create_groups_accumulator() now use a match
on eval_mode to instantiate the appropriate accumulator type
- Each accumulator has a dedicated inner update_sum function without any
eval mode branching
- The Legacy/Ansi accumulators don't carry the has_all_nulls field since
they don't need it
- Added helper methods like overflowed() and group_overflowed() for the Try
variants to improve readability
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
