Jefffrey commented on code in PR #19702: URL: https://github.com/apache/datafusion/pull/19702#discussion_r2674579346
########## datafusion/sqllogictest/test_files/spark/array/array_repeat.slt: ########## @@ -15,13 +15,43 @@ # specific language governing permissions and limitations # under the License. -# This file was originally created by a porting script from: -# https://github.com/lakehq/sail/tree/43b6ed8221de5c4c4adbedbb267ae1351158b43c/crates/sail-spark-connect/tests/gold_data/function -# This file is part of the implementation of the datafusion-spark function library. -# For more information, please see: -# https://github.com/apache/datafusion/issues/15914 - -## Original Query: SELECT array_repeat('123', 2); -## PySpark 3.5.5 Result: {'array_repeat(123, 2)': ['123', '123'], 'typeof(array_repeat(123, 2))': 'array<string>', 'typeof(123)': 'string', 'typeof(2)': 'int'} -#query -#SELECT array_repeat('123'::string, 2::int); + Review Comment: Could we have some array input tests too? For example: ```sql query ? SELECT array_repeat(column1, column2) FROM VALUES ('123', 2), ('4', 1), ('5', 0), (NULL, 1), ('1', NULL); ``` etc. ########## datafusion/spark/src/function/mod.rs: ########## @@ -33,6 +33,7 @@ pub mod lambda; pub mod map; pub mod math; pub mod misc; +pub mod null_utils; Review Comment: ```suggestion mod null_utils; ``` Don't think this needs to be public -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
