shehabgamin commented on issue #15916: URL: https://github.com/apache/datafusion/issues/15916#issuecomment-3727484151
> Hi. Could I take this? Looks like work for this has been stale for a while. @carlosahs That would be great! This is already implemented in Sail, so you can copy it over if you’d like. Note that you’ll need to modify the test cases, since Sail speaks Spark SQL dialect. Here are some handy links: - https://github.com/lakehq/sail/blob/8d4b40c625c7943cc1b46dedc4da427ee42bf9fb/crates/sail-function/src/scalar/math/spark_ceil_floor.rs - https://github.com/lakehq/sail/blob/8d4b40c625c7943cc1b46dedc4da427ee42bf9fb/crates/sail-plan/src/function/scalar/math.rs#L320-L391 - https://github.com/lakehq/sail/blob/8d4b40c625c7943cc1b46dedc4da427ee42bf9fb/python/pysail/tests/spark/function/test_ceil.txt - https://github.com/lakehq/sail/blob/70c159eddb53bd27ad5528e8daae19aa9f891b06/python/pysail/tests/spark/function/test_floor.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
