vbarua commented on code in PR #18987:
URL: https://github.com/apache/datafusion/pull/18987#discussion_r2677588222
##########
datafusion/substrait/src/logical_plan/consumer/expr/scalar_function.rs:
##########
@@ -42,6 +44,33 @@ pub async fn from_scalar_function(
};
let fn_name = substrait_fun_name(fn_signature);
+ if fn_name == "outer_reference" {
Review Comment:
Substrait already has a mechanism for handling outer references via the
[OuterReference](https://github.com/substrait-io/substrait/blob/92d2e757a330f9c973bb566817dc92afd1badcb2/proto/substrait/algebra.proto#L1592-L1598)
root_type inside of a FieldReference.
Defining a custom function like you have here means that other systems won't
be able to understand these plans, and DataFusion won't understands plans from
other systems that use the standard mechanism for outer references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
