adriangb commented on issue #19664: URL: https://github.com/apache/datafusion/issues/19664#issuecomment-3731160034
I see the argument for not using a builder here. What triggered me to leave the comment was seeing two sequential arguments with the same type (input_partition, and num_partitions). A couple weeks ago I spent *hours* debugging `let (file_schema, table_schema) = some_function()` so maybe I just have PTSD from that. I feel it’s easy to get the arguments mixed up and it’s then impossible to debug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
