alamb commented on PR #18542: URL: https://github.com/apache/datafusion/pull/18542#issuecomment-3733333793
Thanks @Jefffrey and @CuteChuanChuan The other thing we could potentially do is keep this PR in reserve and wait for the doc formatting feature to become stable 🤔 The more I have thought about this the more I can see why it would be wise not to require nightly for our development flow. On one hand, I suspect most people will still be able to run `cargo fmt` with the stable version of rust and it will be fine (as they won't be adding examples). However, I do think it will be annoying for people who add new examples, which maybe we don't want to discentivize But I am still torn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
