nuno-faria commented on PR #1337: URL: https://github.com/apache/datafusion-python/pull/1337#issuecomment-3735194349
@timsaucer I did a quick check and it appears now that the query does not block as it once did. So batches are continuously generated, meaning the `sleep(INTERVAL_CHECK_SIGNALS) => ...` branch of `wait_for_future` is never called. One way to solve this would be to put the `py.check_signals()` code before the `tokio::select!` (in addition to the `sleep(INTERVAL_CHECK_SIGNALS)` branch). That way, we ensure that we check for the interrupt before a batch is produced. However, I'm not sure if this would negatively impact performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
