timsaucer commented on PR #1338: URL: https://github.com/apache/datafusion-python/pull/1338#issuecomment-3735523264
> @timsaucer I agree that it would be better to have something more deterministic. However, I think we still need a test to interrupt queries that continuously generate new batches, and therefore do not have the opportunity to check for interrupts ([#1337 (comment)](https://github.com/apache/datafusion-python/pull/1337#issuecomment-3735194349)). For example, a really long generator (`select * from generate_series(1, 1000000000000000000)`). This is a good point. I updated the unit test and combined them to check for fast/slow responses and either collect or stream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
