mkleen commented on PR #18806: URL: https://github.com/apache/datafusion/pull/18806#issuecomment-3773697128
> Thank you for this @duongcongtoai and @kosiew > > Our friends at CMU were just asking about this so it was great to see a PR already started > > I left some comments. My biggest ones are: > > 1. Can we find a way to unify the schema stacks (rather than having both a field and a stack)? > > 2. Can we restrict this PR to just planning (aka no changes to the optimizer or other stages) -- maybe with tests focused only on planning, such as https://github.com/apache/datafusion/blob/4e0161d99cc6558679abd1889ddf9763eed25cfc/datafusion/sql/tests/sql_integration.rs#L4380-L4398 If it's ok, i can give this a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
