tobixdev commented on PR #18552: URL: https://github.com/apache/datafusion/pull/18552#issuecomment-3777489622
Also thank you @paleolimbot for the continued discussion. I think the approach of just starting to support some use cases where a session is available seems like a very pragmatic approach. This would allow us to move forward with some features. Considering this PR, we would be able to implement the record batch pretty printing (we have a session there), but the Logical Plan pretty-printing would then require passing a registry. I am very open to approaches similar to `BoundExtension` but I think I am missing a key point in your proposal. I don't really see how the `BoundExtension` approach is different of just using the extension type registry, create the `LogicalType` instance for the metadata via the `ExtensionTypeRegistration`, and then call `create_array_formatter` on the `LogicalType`. Apart from that I think we have had very good inputs in this (and related) discussions (Thanks @paleolimbot @alamb @tustvold ) and the purpose of this PR (sparking this discussions) have been fulfilled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
