kazantsev-maksim commented on code in PR #3004: URL: https://github.com/apache/datafusion-comet/pull/3004#discussion_r2713418900
########## native/spark-expr/src/csv_funcs/csv_write_options.rs: ########## @@ -0,0 +1,61 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::fmt::{Display, Formatter}; + +#[derive(Debug, Clone, Hash, PartialEq, Eq)] +pub struct CsvWriteOptions { + pub delimiter: String, + pub quote: String, + pub escape: String, + pub null_value: String, + pub quote_all: bool, + pub ignore_leading_white_space: bool, + pub ignore_trailing_white_space: bool, +} + +impl Display for CsvWriteOptions { + fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { + write!( Review Comment: Thanks, fixed. ########## spark/src/main/scala/org/apache/comet/serde/structs.scala: ########## @@ -230,3 +232,68 @@ object CometJsonToStructs extends CometExpressionSerde[JsonToStructs] { } } } + +object CometStructsToCsv extends CometExpressionSerde[StructsToCsv] { + + private val incompatibleDataTypes = Seq(DateType, TimestampType, TimestampNTZType, BinaryType) + + override def getSupportLevel(expr: StructsToCsv): SupportLevel = { + val dataTypes = expr.inputSchema.fields.map(_.dataType) + val containsComplexType = dataTypes.exists(DataTypeSupport.isComplexType) + if (containsComplexType) { + return Unsupported( + Some( + s"The schema ${expr.inputSchema} is not supported because it includes a complex type")) + } + val containsIncompatibleDataTypes = dataTypes.exists(incompatibleDataTypes.contains) + if (containsIncompatibleDataTypes) { + return Incompatible( + Some( + s"The schema ${expr.inputSchema} is not supported because " + + s"it includes a incompatible data types: $incompatibleDataTypes")) + } + Compatible() Review Comment: Thanks, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
