paleolimbot commented on issue #18223: URL: https://github.com/apache/datafusion/issues/18223#issuecomment-3780788602
> paleolimbot maybe we should discuss your BoundExtension approach before starting with that. Anything that de-couples the `LogicalType` from the trait members that resolve extension capability is what I had in mind...basically just move `fn create_array_formatter<'fmt>(...)` to a trait that is not `LogicalType` and call it something (I called it `BoundExtension` in that comment but it could also be `DynExtensionType`, `TypeExtension`, `DFExtensionType` or anything else). The idea is that you can do exactly what you did in your PR without changing much (`impl BoundExtension for Uuid`). > From my perspective, the discussion PR can be separated into three PRs It would be great to get confirmation that this is the approach somebody who can merge this would like. I personally quite liked the end-to-end draft PR you put together because it implements the required functionality and immediately does something useful. Without the integration with `FieldMetadata` I think the whole thing is only a few hundred lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
