Dandandan commented on code in PR #19932:
URL: https://github.com/apache/datafusion/pull/19932#discussion_r2717103532
##########
datafusion/common/src/config.rs:
##########
@@ -1115,6 +1115,18 @@ config_namespace! {
/// See:
<https://trino.io/docs/current/admin/dynamic-filtering.html#dynamic-filter-collection-thresholds>
pub hash_join_inlist_pushdown_max_distinct_values: usize, default = 150
+ /// When true, pushes down hash table references for membership checks
in hash joins
+ /// when the build side is too large for InList pushdown.
+ /// When false, no membership filter is created when InList thresholds
are exceeded.
+ /// Default: true
+ pub hash_join_map_pushdown: bool, default = true
Review Comment:
Perhaps it is also good to differentiate between array map (`contains_keys`)
vs hash map (`contains_hashes`). The first one should be much cheaper (no
hashing / hash probing necessary).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
