kumarUjjawal commented on code in PR #19931:
URL: https://github.com/apache/datafusion/pull/19931#discussion_r2719490900
##########
datafusion/proto/src/physical_plan/from_proto.rs:
##########
@@ -737,6 +737,8 @@ impl TryFrom<&protobuf::FileSinkConfig> for FileSinkConfig {
insert_op,
keep_partition_by_columns: conf.keep_partition_by_columns,
file_extension: conf.file_extension.clone(),
+ // For deserialized plans, use extension heuristic (backward
compatible)
Review Comment:
Thanks for the feedback. You were right, I made some changes based on the
input. Let me know if this looks better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
