alamb commented on code in PR #19931:
URL: https://github.com/apache/datafusion/pull/19931#discussion_r2722401497
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -2048,11 +2048,17 @@ impl DataFrame {
.build()?
};
+ // Build copy options, including single_file_output if explicitly set
+ let mut copy_options: HashMap<String, String> = HashMap::new();
Review Comment:
since this seems to be a common piece of functionality, what do you think
about creating a common function that takes a `DataFrameWriteOptions` and
returns a `CopyOptions`?
##########
datafusion-examples/examples/data_io/parquet_encrypted.rs:
##########
@@ -55,7 +55,7 @@ pub async fn parquet_encrypted() ->
datafusion::common::Result<()> {
// Create a temporary file location for the encrypted parquet file
let tmp_source = TempDir::new()?;
- let tempfile = tmp_source.path().join("cars_encrypted");
+ let tempfile = tmp_source.path().join("cars_encrypted.parquet");
Review Comment:
does it need to be called .parquet even though the dataframe explicitly says
`write_parquet`? Or is this just to clean up the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
