Jefffrey commented on PR #19916: URL: https://github.com/apache/datafusion/pull/19916#issuecomment-3803602542
I'm a little confused by the intent of this PR; the body seems to imply it fixes cases where parentheses aren't being added to preserve precedence, but I'm fairly sure we already have this code? Especially judging by the discussion on #16054 Moreover the example in the PR body is incorrect with the behaviour of this PR: > After: > ``` > > select (1+2)*3; > +------------------------------------+ > | (Int64(1) + Int64(2)) * Int64(3) | > +------------------------------------+ > ``` I tried out this PR with cli and the parentheses aren't added because this is a schema name. And there is a test added in this PR contradicting this statement. Could you help clarify what exactly this PR is achieving that we don't have on main? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
