brancz commented on code in PR #19895:
URL: https://github.com/apache/datafusion/pull/19895#discussion_r2735247027
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -722,6 +729,15 @@ impl PartialOrd for ScalarValue {
if k1 == k2 { v1.partial_cmp(v2) } else { None }
}
(Dictionary(_, _), _) => None,
+ (RunEndEncoded(rf1, vf1, v1), RunEndEncoded(rf2, vf2, v2)) => {
+ // Don't compare if the run ends fields don't match (it is
effectively a different datatype)
Review Comment:
I'm not sure this is exactly what we want. The run arrays could be logically
identical, but their index types might differ. I don't think we'd want the
scalar not to equal in that case. I realize that's not what we have for
dictionaries either, but is that really the intention of scalars? My
understanding has always been that the integer width of codes should be
irrelevant from a logical equality perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
