kumarUjjawal opened a new pull request, #20043:
URL: https://github.com/apache/datafusion/pull/20043
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #19723.
## Rationale for this change
- The API is not “reverse-only”: it takes an arbitrary requested ordering
and can accept/deny/partially match it, so try_pushdown_sort is a more accurate
name.
- FileScanConfig::rebuild_with_source shouldn’t assume reversal; reversal is
only valid when it helps satisfy the caller’s requested order.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
- Renames FileSource::try_reverse_output to FileSource::try_pushdown_sort
(keeps try_reverse_output as a deprecated shim for compatibility).
- Updates Parquet’s implementation and internal call sites to use the new
name.
- Updates FileScanConfig::rebuild_with_source to take the caller’s
requested ordering and only reverse file_groups when the request is actually a
reverse of the current
output_ordering (adds a unit test).
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
- Yes: FileSource implementers should prefer try_pushdown_sort;
try_reverse_output remains but is deprecated.
- Slight behavioral change: file group reversal during sort pushdown is
now conditional instead of always reversing
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
