ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1380380203
##########
include/api/Metrics.h:
##########
@@ -45,23 +45,47 @@ class Metrics
private:
using self_type = Metrics;
+ class AtomicType
+ {
+ friend class Metrics;
+
+ public:
+ AtomicType() = default;
+ virtual ~AtomicType() = default;
Review Comment:
Making this virtual doubles the size of instances of this type. Why is it
necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
