ywkaras commented on code in PR #10694:
URL: https://github.com/apache/trafficserver/pull/10694#discussion_r1380587893
##########
include/proxy/http2/Http2ServerSession.h:
##########
@@ -72,13 +72,13 @@ class Http2ServerSession : public PoolableSession, public
Http2CommonSession
void
increment_current_active_connections_stat() override
{
- Metrics::increment(http2_rsb.current_active_server_connection_count);
+
Metrics::Gauge::increment(http2_rsb.current_active_server_connection_count);
Review Comment:
Since you had to change all of these anyway, why didn't you make increment
and decrement non-static member functions:
`http2_rsb.current_active_server_connection_count->increment()`. It's
shorter, and you would get a compiler error if you tried to decrement a counter
rather than a gauge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
