JosiahWI commented on code in PR #10724:
URL: https://github.com/apache/trafficserver/pull/10724#discussion_r1382168471
##########
cmake/AutoOptionHelpers.cmake:
##########
@@ -21,17 +21,20 @@ set(GLOBAL_AUTO_OPTION_VARS "")
function(_REGISTER_AUTO_OPTION _NAME _FEATURE_VAR _DESCRIPTION _DEFAULT)
add_custom_target(${_NAME}_target)
- set_target_properties(${_NAME}_target
- PROPERTIES
- AUTO_OPTION_FEATURE_VAR ${_FEATURE_VAR}
- )
+ set_target_properties(${_NAME}_target PROPERTIES AUTO_OPTION_FEATURE_VAR
${_FEATURE_VAR})
Review Comment:
I thought about this a little more. If the formatter is not run from the
project root, it presumably will not detect our config and will use its
defaults. We need a way to be confident this is actually our config and not the
default one. I think we ran the formatter across the entire repository when we
first started using it, so this module should **not** need to be reformatted
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
