JosiahWI commented on code in PR #10724:
URL: https://github.com/apache/trafficserver/pull/10724#discussion_r1382169359
##########
cmake/AutoOptionHelpers.cmake:
##########
@@ -21,17 +21,20 @@ set(GLOBAL_AUTO_OPTION_VARS "")
function(_REGISTER_AUTO_OPTION _NAME _FEATURE_VAR _DESCRIPTION _DEFAULT)
add_custom_target(${_NAME}_target)
- set_target_properties(${_NAME}_target
- PROPERTIES
- AUTO_OPTION_FEATURE_VAR ${_FEATURE_VAR}
- )
+ set_target_properties(${_NAME}_target PROPERTIES AUTO_OPTION_FEATURE_VAR
${_FEATURE_VAR})
Review Comment:
Having a pre-commit hook and a CMake target like we do for clang-format
would help with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
