SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383773953
##########
include/iocore/net/ConnectionTracker.h:
##########
@@ -107,49 +111,54 @@ class ConnectionTracker
MatchType const &_match_type; ///< Type of matching.
};
- IpEndpoint _addr; ///< Remote IP address.
- CryptoHash _hash; ///< Hash of the FQDN.
- MatchType _match_type; ///< Type of matching.
- std::string _fqdn; ///< Expanded FQDN, set if matching on FQDN.
- int min_keep_alive_conns; /// < Min keep alive conns on this server group
- Key _key; ///< Pre-assembled key which references the
following members.
+ enum class DirectionType { INBOUND, OUTBOUND };
+
+ DirectionType _direction; ///< Whether the group is for inbound
or outbound connections.
+ IpEndpoint _addr; ///< Remote IP address.
+ CryptoHash _hash; ///< Hash of the FQDN.
+ MatchType _match_type{MATCH_IP}; ///< Type of matching.
+ std::string _fqdn; ///< Expanded FQDN, set if matching on
FQDN.
+ int min_keep_alive_conns{0}; /// < Min keep alive conns on this
server group
+ Key _key; ///< Pre-assembled key which
references the following members.
+ std::chrono::seconds &_alert_delay; ///< Alert delay in seconds.
Review Comment:
"Reference to alert delay based on connection direction"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
