SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383817545
##########
include/iocore/net/ConnectionTracker.h:
##########
@@ -166,9 +175,9 @@ class ConnectionTracker
void blocked();
/// Clear all reservations.
void clear();
- /// Drop the reservation - assume it will be cleaned up elsewhere.
+ /// Transfer ownership of the group outside of this state.
/// @return The group for this reservation.
- Group *drop();
+ std::shared_ptr<Group> drop();
Review Comment:
Why return the group? The original code needed that to track the memory
because it was an intrusive container and the pointer was useful for putting it
back. If it's reference counted, Otherwise it's useless computation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
