SolidWallOfCode commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1388787161
##########
src/iocore/net/UnixNetVConnection.cc:
##########
@@ -1449,6 +1455,23 @@ UnixNetVConnection::remove_from_active_queue()
}
}
+void
+UnixNetVConnection::enable_inbound_connection_tracking(std::shared_ptr<ConnectionTracker::Group>
group)
+{
+ ink_assert(nullptr == conn_track_group);
+ conn_track_group = std::move(group);
Review Comment:
The `move` is wrong. I'm not sure which way, but either you're copying to
another shared pointer, in which case just assign, or it's a direct instance in
which you now have dangling pointers elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
