bneradt commented on code in PR #10688:
URL: https://github.com/apache/trafficserver/pull/10688#discussion_r1383863839
##########
include/iocore/net/ConnectionTracker.h:
##########
@@ -166,9 +175,9 @@ class ConnectionTracker
void blocked();
/// Clear all reservations.
void clear();
- /// Drop the reservation - assume it will be cleaned up elsewhere.
+ /// Transfer ownership of the group outside of this state.
/// @return The group for this reservation.
- Group *drop();
+ std::shared_ptr<Group> drop();
Review Comment:
So the calling code can share ownership of the group. That's the point of
the call. Once the reference count goes to zero, the group is removed from the
table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
