cmcfarlen commented on code in PR #11675:
URL: https://github.com/apache/trafficserver/pull/11675#discussion_r1716998529
##########
src/iocore/net/UnixNetAccept.cc:
##########
@@ -478,10 +478,10 @@ NetAccept::acceptEvent(int event, void *ep)
if ((res = accept_fn(this, e, false)) < 0) {
Metrics::Gauge::decrement(net_rsb.accepts_currently_open);
/* INKqa11179 */
- Warning("Accept on port %d failed with error no %d",
ats_ip_port_host_order(&server.addr), res);
+ Warning("Accept on port %d failed with error no %d",
ats_ip_port_host_order(&server.accept_addr), res);
Review Comment:
It looks like it uses accept_addr to specify what address/port to bind to,
but then it reads the actual bound address into addr. I'm not sure this needs
both since it's not inheriting from Connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
