JosiahWI commented on code in PR #11675:
URL: https://github.com/apache/trafficserver/pull/11675#discussion_r1717223014
##########
src/iocore/net/UnixNetAccept.cc:
##########
@@ -478,10 +478,10 @@ NetAccept::acceptEvent(int event, void *ep)
if ((res = accept_fn(this, e, false)) < 0) {
Metrics::Gauge::decrement(net_rsb.accepts_currently_open);
/* INKqa11179 */
- Warning("Accept on port %d failed with error no %d",
ats_ip_port_host_order(&server.addr), res);
+ Warning("Accept on port %d failed with error no %d",
ats_ip_port_host_order(&server.accept_addr), res);
Review Comment:
These aren't interchangeable, because the address can be set to something
different if `accept_addr` is not an IP:
```cpp
int
Server::listen(bool non_blocking, const NetProcessor::AcceptOptions &opt)
{
ink_assert(!sock.is_ok());
int res = 0;
socklen_t namelen;
int prot = IPPROTO_TCP;
if (!ats_is_ip(&accept_addr)) {
ats_ip4_set(&addr, INADDR_ANY, 0);
} else {
ats_ip_copy(&addr, &accept_addr);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
