bneradt commented on code in PR #12320:
URL: https://github.com/apache/trafficserver/pull/12320#discussion_r2195596846
##########
tests/gold_tests/cripts/cripts.test.py:
##########
@@ -19,6 +19,9 @@
import os
+# Needed if we want to use sed -i '' on macOS, but autest doesn't like that ...
+# import platform
+
Review Comment:
Let's remove this since we're using perl.
##########
tests/gold_tests/cripts/cripts.test.py:
##########
@@ -66,7 +76,12 @@ def updateCompilerForTest(self):
compiler_source = os.path.join(p.Variables.RepoDir, 'tools', 'cripts',
'compiler.sh')
p.Setup.Copy(compiler_source, self._compiler_location)
install_dir = os.path.split(p.Variables.BINDIR)[0]
- p.Command = f'sed -i "s|\"/tmp/ats\"|{install_dir}|g"
{self._compiler_location}'
+ sed_in_place = "-i ''" if platform.system() == 'Darwin' else "-i"
+ # autest doesn't like the -i '' that's necessary on Darwin/macOS
+ # sed_in_place = "-i ''" if platform.system() == 'Darwin' else "-i"
+ # p.Command = f"sed -i '' 's|\"/tmp/ats\"|\"{install_dir}\"|'
{self._compiler_location}"
Review Comment:
Let's just remove these lines since they aren't used now that we're using
perl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
