zwoop commented on code in PR #12320: URL: https://github.com/apache/trafficserver/pull/12320#discussion_r2195685451
########## tests/gold_tests/cripts/cripts.test.py: ########## @@ -19,6 +19,9 @@ import os +# Needed if we want to use sed -i '' on macOS, but autest doesn't like that ... +# import platform + Review Comment: I intentionally left this in as a reminder as to why "sed -i" has problematic, such that we don't forget to either fix autest, or not repeat the same headaches again. ########## tests/gold_tests/cripts/cripts.test.py: ########## @@ -19,6 +19,9 @@ import os +# Needed if we want to use sed -i '' on macOS, but autest doesn't like that ... +# import platform + Review Comment: I intentionally left this in as a reminder as to why "sed -i" was problematic, such that we don't forget to either fix autest, or not repeat the same headaches again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
