JakeChampion commented on code in PR #12505:
URL: https://github.com/apache/trafficserver/pull/12505#discussion_r2354648118
##########
plugins/compress/configuration.cc:
##########
@@ -190,6 +191,18 @@ HostConfiguration::is_status_code_compressible(const
TSHttpStatus status_code) c
return it != compressible_status_codes_.end();
}
+static std::string_view
+strip_params(std::string_view v)
+{
+ if (auto pos = v.find(';'); pos != std::string_view::npos) {
+ v = v.substr(0, pos);
+ }
+ // trim trailing spaces
+ while (!v.empty() && isspace(static_cast<unsigned char>(v.back())))
+ v.remove_suffix(1);
+ return v;
Review Comment:
swoc::TextView looks good, I could not get `tv.rtrim_if(&isspace)` to
compile, i went with this instead
```c++
std::string_view
strip_params(std::string_view v)
{
swoc::TextView tv{v};
tv = tv.take_prefix_at(';');
tv.rtrim(swoc::CharSet(" \t\n\r\f\v"));
return tv;
}
```
https://github.com/apache/trafficserver/pull/12505/commits/f07156d0c0dc921a8d96bbe2ce6969f951f15395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
