Copilot commented on code in PR #12505:
URL: https://github.com/apache/trafficserver/pull/12505#discussion_r2365705615
##########
plugins/compress/configuration.cc:
##########
@@ -190,6 +195,15 @@ HostConfiguration::is_status_code_compressible(const
TSHttpStatus status_code) c
return it != compressible_status_codes_.end();
}
+std::string_view
+strip_params(std::string_view v)
+{
+ swoc::TextView tv{v};
+ tv = tv.take_prefix_at(';');
+ tv.rtrim_if([](int ch) { return std::isspace(ch); });
+ return tv;
Review Comment:
[nitpick] The function `strip_params` creates a `swoc::TextView` from
`std::string_view` but returns `std::string_view`. This conversion pattern
could be confusing. Consider either working entirely with `std::string_view` or
documenting why the conversion is necessary.
```suggestion
// Find the first ';' and trim to that position
size_t pos = v.find(';');
if (pos != std::string_view::npos) {
v = v.substr(0, pos);
}
// Remove trailing whitespace
while (!v.empty() && std::isspace(static_cast<unsigned char>(v.back()))) {
v.remove_suffix(1);
}
return v;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
