PSUdaemon commented on PR #12567: URL: https://github.com/apache/trafficserver/pull/12567#issuecomment-3441108539
> > I'm not sure if I totally follow this, but it appears to be more about copyright. I removed WyHash to remove questions about the source of code. We can add that or other hash functions later and debate that issue there. This commit also now has more infrastructure that Craig and @jrushford requested. > > Thank you for the update. > > This is just a suggestion, but it would be more interesting if we could add the support for WyHash or other algorithms without changing ATS core. Apparently, WyHash has a successor (Rapidhash). Adding the support for WyHash might only increase the size of code we have to maintain. I'd suggest introducing `TSHashAlgoRegister(const char *name, HashAlgoMethod *method)` or some such so that users can add preferred hash algorithms by using/writing TS plugins. It'd also allow us to write a "hash" algorithm that is more like mapping and that could be useful for testing or experiments. I'll definitely consider this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
