PSUdaemon commented on PR #12567: URL: https://github.com/apache/trafficserver/pull/12567#issuecomment-3476962306
> Seeing Rushford's comment, makes you wonder why we have two implementations of this underlying consistent hashing? Shouldn't the old parent.config hashing, and the new strategies.yaml hashing use the same core hash functions / code ? The hash functions and consistent hash ring implementation are the same between them. The differences are `ParentConsistentHash` and `NextHopConsistentHash`. `NextHopConsistentHash` is a superset of `ParentConsistentHash`. It's mostly about the flexibility of the classes. For example, `ParentConsistentHash` has a primary and a secondary ring, but `NextHopConsistentHash` has a `Vec` of rings. So you have have an arbitrary amount. `NextHopConsistentHash` has more options for hash keys as well. They could be unified, however I think what @jrushford was getting at was that we would deprecate `parent.config` in favor of `strategies.yaml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
