bneradt commented on code in PR #12607:
URL: https://github.com/apache/trafficserver/pull/12607#discussion_r2461832349
##########
plugins/cachekey/pattern.h:
##########
@@ -18,29 +18,23 @@
/**
* @file pattern.h
- * @brief PRCE related classes (header file).
+ * @brief Regex related classes (header file).
*/
#pragma once
#include "tscore/ink_defs.h"
-
-#ifdef HAVE_PCRE_PCRE_H
-#include <pcre/pcre.h>
-#else
-#include <pcre.h>
-#endif
+#include "tsutil/Regex.h"
#include "common.h"
/**
- * @brief PCRE matching, capturing and replacing
+ * @brief Regex matching, capturing and replacing
*/
class Pattern
{
public:
- static const int TOKENCOUNT = 10; /**< @brief Capturing groups
$0..$9 */
- static const int OVECOUNT = TOKENCOUNT * 3; /**< @brief pcre_exec() array
count, handle 10 capture groups */
+ static const int TOKENCOUNT = 10; /**< @brief Capturing groups $0..$9 */
Pattern();
virtual ~Pattern();
Review Comment:
I don't think there's inheritance of Pattern, right? We should be able to
remove `virtual` and set this ` = default;` here. And remove
`Pattern::~Pattern() {}` in the .cc file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
