bryancall commented on PR #12607: URL: https://github.com/apache/trafficserver/pull/12607#issuecomment-3499081445
## Addressed Review Comments ### ✅ Fixed: Destructor (pattern.h line 40) Removed `virtual` keyword from destructor and changed to `= default` as suggested by @bneradt. Pattern class has no inheritance, so the virtual destructor was unnecessary. **Changes:** - Header: Changed `virtual ~Pattern();` to `~Pattern() = default;` - Implementation: Removed empty destructor from pattern.cc ### ℹ️ Copilot Comments - No Changes Needed **Bounds Check (pattern.cc line 273):** This is a false positive. The bounds check already exists at lines 265-268 where all tokens are validated before use in the loop. **String Construction (pattern.cc line 229):** The code is already consistent - both line 229 and line 277 use the same pattern: `String dst(capture.data(), capture.length());` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
