zwoop commented on code in PR #12602:
URL: https://github.com/apache/trafficserver/pull/12602#discussion_r2482428900
##########
doc/admin-guide/files/records.yaml.en.rst:
##########
@@ -383,6 +383,18 @@ Thread Variables
will create its own domain socket with a ``-<thread id>`` suffix added to
the
end of the path.
+.. ts:cv:: CONFIG proxy.config.exec_thread.event_time_update_rate INT 10
Review Comment:
Instead of spelling out that this is reloadable etc., you should add
```
:reloadable:
```
##########
src/iocore/eventsystem/EventSystem.cc:
##########
@@ -44,6 +44,9 @@ ink_event_system_init(ts::ModuleVersion v)
RecEstablishStaticConfigInt32(thread_freelist_low_watermark,
"proxy.config.allocator.thread_freelist_low_watermark");
+ extern int event_time_update_rate;
+ RecEstablishStaticConfigInt32(event_time_update_rate,
"proxy.config.exec_thread.event_time_update_rate");
Review Comment:
Not sure I like the name of this config :)
Feels like it should be clear that it's for event metrics, and not the event
system itself ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
