zwoop commented on code in PR #12602:
URL: https://github.com/apache/trafficserver/pull/12602#discussion_r2511360268
##########
doc/admin-guide/files/records.yaml.en.rst:
##########
@@ -383,6 +383,19 @@ Thread Variables
will create its own domain socket with a ``-<thread id>`` suffix added to
the
end of the path.
+.. ts:cv:: CONFIG proxy.config.exec_thread.loop_time_update_probability INT 10
+ :reloadable:
+
+ This dynamically loadable setting controls the rate that exec thread loop
timestamps are
Review Comment:
Should this say "this dynamic reloadable" ? Or just "this reloadable" ?
##########
src/iocore/eventsystem/UnixEThread.cc:
##########
@@ -53,6 +54,7 @@ char const *const EThread::Metrics::Slice::STAT_NAME[] = {
};
int thread_max_heartbeat_mseconds = THREAD_MAX_HEARTBEAT_MSECONDS;
+int loop_time_update_probability = 10;
Review Comment:
Mostly a question: Would it make sense if we were to start making these
types of config driven globals std::atomic ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
