bneradt commented on code in PR #12643:
URL: https://github.com/apache/trafficserver/pull/12643#discussion_r2499713980
##########
src/records/RecordsConfig.cc:
##########
@@ -1565,6 +1568,98 @@ validate_check_type_has_regex()
return true;
}
+//-------------------------------------------------------------------------
+// Compile-time validation helpers for RECC_INT patterns
+//-------------------------------------------------------------------------
+
+namespace
+{
+constexpr bool
+is_digit(char c)
+{
+ return c >= '0' && c <= '9';
+}
+
+// Parse an integer (possibly negative) at compile time
+// Updates index i to point past the parsed number
+// TODO: C++23 has std::from_chars for constexpr integer parsing
Review Comment:
Sounds good, but use `@param[in]` and `@param[out]`. For some reason, the
AI's don't like the `[in]`/`[out]` qualifiers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
