moonchen commented on code in PR #12643:
URL: https://github.com/apache/trafficserver/pull/12643#discussion_r2500895970
##########
src/records/RecUtils.cc:
##########
@@ -390,23 +393,56 @@ recordRegexCheck(const char *pattern, const char *value)
bool
recordRangeCheck(const char *pattern, const char *value)
{
- char *p = const_cast<char *>(pattern);
- Tokenizer dashTok("-");
-
- if (recordRegexCheck("^[0-9]+$", value)) {
- while (*p != '[') {
- p++;
- } // skip to '['
- if (dashTok.Initialize(++p, COPY_TOKS) == 2) {
- int l_limit = atoi(dashTok[0]);
- int u_limit = atoi(dashTok[1]);
- int val = atoi(value);
- if (val >= l_limit && val <= u_limit) {
- return true;
- }
- }
+ std::string_view sv_pattern(pattern);
+
+ // Find '[' and ']'
+ auto start = sv_pattern.find('[');
+ if (start != 0) {
+ Warning("recordRangeCheck: pattern '%s' does not start with '['", pattern);
+ return false; // No '[' found
Review Comment:
Starting with a [ is a stronger requirement than containing a [. We should
tell the dev the stronger requirement up front to avoid multiple iterations
when fixing the range syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
