Copilot commented on code in PR #12755:
URL: https://github.com/apache/trafficserver/pull/12755#discussion_r2621099788
##########
tests/gold_tests/tls/ssl_key_dialog.test.py:
##########
@@ -39,7 +39,7 @@
'proxy.config.ssl.server.private_key.path':
'{0}'.format(ts.Variables.SSLDir),
})
-ts.Disk.ssl_multicert_config.AddLines(
+ts.Disk.ssl_multicert_yaml.AddLines(
[
'dest_ip=* ssl_cert_name=passphrase.pem ssl_key_name=passphrase.key
ssl_key_dialog="exec:/bin/bash -c \'echo -n passphrase\'"',
])
Review Comment:
This test is still using legacy format syntax after changing to
ssl_multicert_yaml. Lines 44-45 contain legacy format entries which should be
converted to YAML format for consistency with the migration pattern.
##########
tests/gold_tests/tls/ssl_key_dialog.test.py:
##########
@@ -63,9 +63,9 @@
tr2 = Test.AddTestRun("Update config files")
# Update the multicert config
-sslcertpath = ts.Disk.ssl_multicert_config.AbsPath
+sslcertpath = ts.Disk.ssl_multicert_yaml.AbsPath
tr2.Disk.File(sslcertpath, id="ssl_multicert_config", typename="ats:config"),
-tr2.Disk.ssl_multicert_config.AddLines(
+tr2.Disk.ssl_multicert_yaml.AddLines(
[
'dest_ip=* ssl_cert_name=passphrase2.pem ssl_key_name=passphrase2.key
ssl_key_dialog="exec:/bin/bash -c \'echo -n passphrase\'"',
])
Review Comment:
The second occurrence in this file also uses legacy format syntax after the
migration. Lines 69-71 should be converted to YAML format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
