brbzull0 commented on code in PR #12755:
URL: https://github.com/apache/trafficserver/pull/12755#discussion_r2623691863


##########
src/traffic_ctl/traffic_ctl.cc:
##########
@@ -137,6 +139,20 @@ main([[maybe_unused]] int argc, const char **argv)
 
   config_command.add_command("registry", "Show configuration file registry", 
Command_Execute)
     .add_example_usage("traffic_ctl config registry");
+
+  // ssl-multicert subcommand
+  auto &ssl_multicert_command =
+    config_command.add_command("ssl-multicert", "Manage ssl_multicert 
configuration").require_commands();
+  ssl_multicert_command.add_command("show", "Show the ssl_multicert 
configuration in JSON format", Command_Execute)

Review Comment:
   By default is JSON??  does it make sense to drop YAML too? should be 
straight forward as the YAML node is what we read from the file.?
   
   if so, I'd suggest  using [mutex 
groups](https://docs.trafficserver.apache.org/en/latest/developer-guide/internal-libraries/ArgParser.en.html#mutually-exclusive-groups)
 for the options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to