maskit commented on code in PR #12763:
URL: https://github.com/apache/trafficserver/pull/12763#discussion_r2624347962
##########
include/iocore/net/NetVConnection.h:
##########
@@ -322,6 +322,24 @@ class NetVConnection : public VConnection, public
PluginUserArgs<TS_USER_ARGS_VC
return 0;
}
+ /**
+ * Capture TLS handshake byte statistics.
+ *
+ * For TLS connections, captures the bytes read/written during the TLS
handshake.
+ * If already captured, returns the stored values.
+ *
+ * @param[out] bytes_in Bytes received during handshake
+ * @param[out] bytes_out Bytes transmitted during handshake
+ * @return true if values were captured on this call, false if already
captured or not applicable
+ */
+ virtual bool
+ capture_tls_handshake_bytes(uint64_t &bytes_in, uint64_t &bytes_out)
Review Comment:
I don't like to see TLS stuff in NetVConnection. `TLSBasicSupport` is
probably a better place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
