maskit commented on code in PR #12763:
URL: https://github.com/apache/trafficserver/pull/12763#discussion_r2624392886
##########
src/proxy/logging/LogAccess.cc:
##########
@@ -2096,6 +2096,27 @@ LogAccess::marshal_client_req_squid_len(char *buf)
return INK_MIN_ALIGN;
}
+/*-------------------------------------------------------------------------
+ Client request squid length plus TLS handshake bytes received for TLS
connections.
+ -------------------------------------------------------------------------*/
+int
+LogAccess::marshal_client_req_squid_len_tls(char *buf)
+{
+ if (buf) {
+ int64_t val = 0;
+
+ if (m_client_request) {
+ val = m_client_request->length_get() +
m_http_sm->client_request_body_bytes;
Review Comment:
What if the handshake has early data? I guess the size of the request gets
double counted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
