zwoop commented on PR #12743: URL: https://github.com/apache/trafficserver/pull/12743#issuecomment-4013432899
> Everything else looks good -- persistence tests are solid, error handling is thorough, and all 8 existing tests pass clean with ASAN on Fedora 43. Just one bug in the revert logic that needs fixing. > > **Other minor observations** (non-blocking, could be follow-up): > > * `_Entry::timestamp` (`time_point`) and `_Entry::length` (`size_t`) are written directly to disk but aren't fixed-width types like `_MapHeader` uses. The VERSION field provides a migration path, so this is fine for now. > * The Cache Groups RST section is missing a `.. _cripts-misc-cache-groups:` anchor label for consistency with other sections. Added the docs link, ignoring the first one (these files are transient, and most certainly won't go between hosts or architectures or ATS versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
