bryancall commented on code in PR #13012:
URL: https://github.com/apache/trafficserver/pull/13012#discussion_r2983176086
##########
tests/gold_tests/timeout/ssl-delay-server.cc:
##########
@@ -199,8 +204,10 @@ main(int argc, char *argv[])
for (;;) {
sfd = accept(listenfd, (struct sockaddr *)nullptr, nullptr);
if (sfd <= 0) {
Review Comment:
Good catch — fixed. Changed to `sfd < 0` since fd 0 is technically valid.
##########
tests/gold_tests/logging/sigusr2.test.py:
##########
@@ -130,9 +130,9 @@ def get_sigusr2_signal_command(self):
# Configure the signaling of SIGUSR2 to traffic_server.
tr1.Processes.Default.Command = diags_test.get_sigusr2_signal_command()
tr1.Processes.Default.Return = 0
-tr1.Processes.Default.Ready = When.FileExists(diags_test.diags_log)
-
-# Configure process order.
+# Configure process order: ts starts first, then rotate moves diags.log,
+# then Default sends SIGUSR2. No Ready condition needed on Default since the
+# StartBefore chain already ensures ts is fully started before rotate runs.
tr1.Processes.Default.StartBefore(rotate_diags_log)
rotate_diags_log.StartBefore(diags_test.ts)
Review Comment:
Not applicable — in the AuTest framework, `StartBefore` waits for the
earlier process's Ready condition (port-up for ATS), not just launch ordering.
By the time TS is ready, `diags.log` has already been created during startup.
There is no race here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
