bneradt commented on code in PR #13012: URL: https://github.com/apache/trafficserver/pull/13012#discussion_r2988477106
########## tests/gold_tests/logging/sigusr2.test.py: ########## @@ -130,9 +130,9 @@ def get_sigusr2_signal_command(self): # Configure the signaling of SIGUSR2 to traffic_server. tr1.Processes.Default.Command = diags_test.get_sigusr2_signal_command() tr1.Processes.Default.Return = 0 -tr1.Processes.Default.Ready = When.FileExists(diags_test.diags_log) - -# Configure process order. +# Configure process order: ts starts first, then rotate moves diags.log, +# then Default sends SIGUSR2. No Ready condition needed on Default since the +# StartBefore chain already ensures ts is fully started before rotate runs. tr1.Processes.Default.StartBefore(rotate_diags_log) rotate_diags_log.StartBefore(diags_test.ts) Review Comment: Actually, let's do this: I'll work on a separate PR for sigusr2. Knowing what I know now, it would be better to organize this test differently to avoid what I think are some race conditions we may be seeing with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
