maskit commented on code in PR #13088: URL: https://github.com/apache/trafficserver/pull/13088#discussion_r3104262721
########## src/iocore/net/TLSCertCompression_zstd.cc: ########## @@ -0,0 +1,82 @@ +/** @file + + Functions for zstd compression/decompression + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#include "TLSCertCompression_zstd.h" +#include "SSLStats.h" +#include <openssl/ssl.h> +#include <zstd.h> + +int +compression_func_zstd(SSL * /* ssl */, CBB *out, const uint8_t *in, size_t in_len) +{ + // TODO Need a cache mechanism inside this function for better performance. + + uint8_t *buf; + unsigned long buf_len = ZSTD_compressBound(in_len); + + if (ZSTD_isError(buf_len) == 1) { + Metrics::Counter::increment(ssl_rsb.cert_compress_zstd_failure); + return 0; + } + + if (CBB_reserve(out, &buf, buf_len) != 1) { + Metrics::Counter::increment(ssl_rsb.cert_compress_zlib_failure); Review Comment: fixed ########## doc/admin-guide/files/records.yaml.en.rst: ########## @@ -4268,6 +4268,39 @@ SSL Termination ``1`` Enables the use of Kernel TLS.. ===== ====================================================================== +.. ts:cv:: CONFIG proxy.config.ssl.server.cert_compression.algorithms STRING + :reloadable: + + A comma-separated list of compression algorithms that |TS| is willing to + use for TLS Certificate Compression + (`RFC 8879 <https://datatracker.ietf.org/doc/html/rfc8879>`_) when |TS| + acts as a TLS server (i.e. accepting connections from clients). When a + connecting client advertises support for one of these algorithms, |TS| will + send its certificate in compressed form, reducing handshake size. + + Supported values: ``zlib``, ``brotli``, ``zstd``. The order determines the + server's preference. An empty value (the default) disables certificate + compression. + + ``brotli`` and ``zstd`` are only available when |TS| is compiled with the + corresponding libraries. + + Example:: + + proxy.config.ssl.server.cert_compression.algorithms: zlib,brotli + +.. ts:cv:: CONFIG proxy.config.ssl.client.cert_compression.algorithms STRING + :reloadable: + + A comma-separated list of compression algorithms that |TS| advertises for + TLS Certificate Compression + (`RFC 8879 <https://datatracker.ietf.org/doc/html/rfc8879>`_) when |TS| + acts as a TLS client (i.e. connecting to origin servers). When the origin + supports one of these algorithms, |TS| will accept and decompress the + certificate. + + Supported values: ``zlib``, ``brotli``, ``zstd``. Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
