maskit commented on code in PR #13088: URL: https://github.com/apache/trafficserver/pull/13088#discussion_r3125787864
########## src/iocore/net/CMakeLists.txt: ########## @@ -116,6 +117,21 @@ if(TS_USE_LINUX_IO_URING) target_link_libraries(inknet PUBLIC ts::inkuring) endif() +# Link cert compression libraries after OpenSSL so that OpenSSL include +# directories appear first in the search order, preventing broad system +# include paths (e.g. from Homebrew's zstd) from shadowing them. +if(HAVE_SSL_CTX_ADD_CERT_COMPRESSION_ALG) + target_sources(inknet PRIVATE TLSCertCompression_zlib.cc) + if(HAVE_BROTLI_ENCODE_H) + target_sources(inknet PRIVATE TLSCertCompression_brotli.cc) + target_link_libraries(inknet PRIVATE brotli::brotlienc brotli::brotlidec) + endif() + if(HAVE_ZSTD_H) + target_sources(inknet PRIVATE TLSCertCompression_zstd.cc) + target_link_libraries(inknet PRIVATE zstd::zstd) + endif() +endif() Review Comment: No, those are only necessary for the library that enables `HAVE_SSL_CTX_ADD_CERT_COMPRESSION_ALG`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
