Hi, Am 30.09.2010 15:37, schrieb Cristian Morales Vega:
> - as_needed (not applied) > Needed to be able to compile/link with --as-needed ld option. > Basically libraries must go to LIBS and not to LDFLAGS. If they are in > LDFLAGS they are inserted before the object files, and the linker only > searchs for undefined symbols in libraries that are *after* the object > files. > In the process libgmerlin_gtk is linked against libgmerlin, that was missing. Applied. > > - cflags (not applied) > This is more cosmetic than anything else. When detecting the CFLAGS > needed by a library the CFLAGS specified by the user were also taken. > This duplicated the user provided cflags multiple times. Ok, applied. Hopefully it doesn't break anything else. > - aliasing (not applied) > It seems equivalent code, but there is a subtle problem in the > original code. See "Casting does not work as expected when > optimization is turned on" in http://gcc.gnu.org/bugs/#nonbugs_c applied. > - no_plugin_sym (wrongly applied? added to EXTRA_DIST but not removed > from pkgdata) > I don't think plugin.sym needs to be installed, true? It's only used > in the linking of plugin files. Yes, and plugin files can be compiled from other packages as well (like gmerlin-avdecoder). So plugin.sym must be in the dev(el) package (and I reversed the half applied patch) > - pkg_config (only half applied? gmerlin-gtk.pc.in was patched but > gmerlin.pc.in wasn't) > When dynamically linking you don't want to include all the > dependencies recursively. Done. Burkhard ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Gmerlin-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/gmerlin-general
